Closed shadowhand closed 8 years ago
As @weierophinney already approved for http-factory why not merge this also?
:+1: I thought that that package was a strict representation of the PSR
I'm not part of either team as a sponsor or contributor, @harikt; I was only expressing approval/agreement.
On Aug 17, 2016 11:45 PM, "Hari K T" notifications@github.com wrote:
As @weierophinney https://github.com/weierophinney already approved for http-factory why not merge this also?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/http-interop/http-middleware/pull/8#issuecomment-240622768, or mute the thread https://github.com/notifications/unsubscribe-auth/AABlV8M1ECZHT7tGhJqvJM33Qr5VP6vdks5qg-NegaJpZM4JnCkF .
@http-interop/http-middleware-contributors one of us needs to sign off on this.
@mindplay-dk please sign off on this so that I can merge and tag a release.
@http-interop/http-middleware-contributors someone please approve this so that we can put it on packagist.
For the record, I don't agree with this change.
But I seem to be the minority, so: approved so we can move ahead.
@mindplay-dk Care to elaborate? I'm curious why you don't agree...
@weierophinney just that, it seems like we're assuming failure. I'd rather assume success, and not have to make a breaking change if the PSR is approved, by then changing the namespace back again. If the PSR is rejected, that is a breaking change, and a namespace change would then be a natural change.
If this was no longer a PSR, the namespace should of course change. At the moment, it is a PSR, albeit unstable, so the PSR namespace seems appropriate.
Anyhow, bigger fish to fry, hence approved in the name of progress :-)
This package does not (at this time) represent an accepted PSR.