http-interop / http-server-middleware

Interface for PSR-15 server middleware
MIT License
22 stars 2 forks source link

1.1.0 seems to be broken #6

Closed shadowhand closed 6 years ago

shadowhand commented 6 years ago

Please see these tests: https://travis-ci.org/zendframework/zend-stratigility/jobs/332049603#L644

So the problem is only on the latest release. It's because the interface extends PSR-15 interface and method defined in the PSR-15 interface typehint against PST-15 interface, not as before interop interface. Basically 1.1.0 has a BC Break...

Refs http-interop/http-server-handler#12 by @webimpress

michalbundyra commented 6 years ago

PR #5 seems to be a good solution !

shadowhand commented 6 years ago

PR #3 should be the correct fix.

shadowhand commented 6 years ago

Fixed by #5.

michalbundyra commented 6 years ago

@shadowhand it can be closed now, we have 1.1.1 in place ! Thanks 👍