http-kit / http-kit.github.com

http-kit.org source code
http-kit.org
10 stars 30 forks source link

Tweak http-kit.org landing page (ready to merge) #4

Closed ptaoussanis closed 11 years ago

ptaoussanis commented 11 years ago

You can see a live copy of the changes here.

shenfeng commented 11 years ago

Hey, Thanks, I like it.

One thing I need to point out: The drop in is not strictly drop in

  1. The option's keys are different, documented here: http://http-kit.org/server.html
  2. http-kit server does not support https (will not in the future)
  3. How to stop it is different

(let [jetty (run-jetty app options)]
  (.stop jetty))

(let [server (run-server app options)]
  (server))

# sample Nginx's config for https
server {
    listen 443 ssl;

    ssl on;
    ssl_certificate /etc/nginx/ssl/xxxxx_ssl.crt;
    ssl_certificate_key /etc/nginx/ssl/xxxx_ssl.key.nopasswd;

     location / { 
        proxy_pass  http://127.0.0.1:9090/;
        proxy_set_header Host $http_host;
    }
}

I was thinking, but could not find a good place to put them.

Any idears?

Cheers

ptaoussanis commented 11 years ago

What about if we describe it as an "(almost) drop-in replacement ..." and have almost be a link to a separate migration.html page which describes these kinds of differences?

That'd also be a good place to mention some of the other possible issues that come up, like the streaming support, the middleware possibly being exposed to the HTTP Kit listener object, etc.

shenfeng commented 11 years ago

What about if we describe it as an "(almost) drop-in replacement ..." and have almost be a link to a separate migration.html page which describes these kinds of differences?

Good idea!