http-party / http-server

a simple zero-configuration command-line http server
MIT License
13.42k stars 1.48k forks source link

Dockerize http-server #790

Open mtozlu opened 2 years ago

mtozlu commented 2 years ago

Dockerization of http-server

Relevant issues

Closes #724

Contributor checklist
Maintainer checklist

Maintainers will do the building, tagging and pushing docker images. These instructions are only for maintainers to release a new version in docker hub;

Building and Tagging the Docker Image

Note: I already have the http-server images built in docker hub in my own repository (which is tozlu/http-server), if you would like to maintain docker images in your own repository, please change README and the build/push scripts above to reflect your username for docker hub.

gaby commented 2 years ago

@mtozlu Have you try running the final bin with Google Distroless images?

FROM gcr.io/distroless/nodejs:16

mtozlu commented 2 years ago

@gaby No. But it looks cool. Should I switch to it? What are the benefits over alpine?

gaby commented 2 years ago

@gaby No. But it looks cool. Should I switch to it? What are the benefits over alpine?

If it runs fine, I would say yes.