search

http-party / node-portfinder

A simple tool to find an open port or domain socket on the current machine
https://github.com/http-party/node-portfinder
Other
882 stars 95 forks source link

no highestPort ts definition in latest version #119

Closed Hishengs closed 2 years ago

Hishengs commented 3 years ago

hi, in the latest version: 1.0.28, there still no ts definition for highestPort

image

image

eriktrom commented 3 years ago

add it and i'll merge.

in fact, if you do add it, consider adding something to the readme that says "contributions for ts defintions are actively merged, but due to the legacy requirements of this code base and the number of packages that depend on it, enhancements in the form of typings are the only thing that are likely to get merged, unless there is a new operating system error we need to handle" (which is really the only thing I check issues for these days - however type definitions are a great way to gain more activity and build a larger community around this lib now that u bring it up.

:)

eriktrom commented 2 years ago

closing - will reopen if code submitted