search

http-party / node-portfinder

A simple tool to find an open port or domain socket on the current machine
https://github.com/http-party/node-portfinder
Other
887 stars 95 forks source link

Replace appveyor and travis with GH actions #133

Closed MasterOdin closed 2 years ago

MasterOdin commented 2 years ago

PR replaces the TravisCI and appveyor configurations with a singular GitHub actions CI workflow, which tests across all major OSes, and expands the test suite to test from 0.12.x up to the currently supported LTS releases of node. I chose to also include 4.x as that's a version that a lot of packages usually break some sort of compatibility where ES2015 wasn't particularly well supported until 6.x LTS releases.

The test suite will run on any push to the repository over any branch, as well as for any pull request that gets made.

Example of the test suite in action: https://github.com/MasterOdin/node-portfinder/actions/runs/2779552712

The big reason for this PR is that with the changes that TravisCI did over the past few years as broken the OSS use case, where you need to apply and re-apply for tokens to continue using the service for free, in addition to moving over to travis-ci.com. For appveyor, now that all CI services offer the ability to run across all major OSes, there's no reason to split off one OS to its own CI. Additionally, by bringing both of these into GH, it makes it easier for others to get up and running and see the actions run within their forks, without having to make accounts and get setup at TravisCI or appveyor.

eriktrom commented 2 years ago

this is awesome

@http-party/portfinder - merging - leave issues and ping me directly if this doesn't work with our organization the way we plan moving forward. If/when that time comes, I'll change it to whatever @http-party concludes best, at that later date.

@MasterOdin - again - thanks a lot for stepping in, pinging me and pulling me back to this project :)