search

http-party / node-portfinder

A simple tool to find an open port or domain socket on the current machine
https://github.com/http-party/node-portfinder
Other
882 stars 95 forks source link

version 1.0.29 doesn't compile with typescript #138

Closed AxelTerizaki closed 2 years ago

AxelTerizaki commented 2 years ago

Probably a syntax error somewhere that throws off the parser. Here's the error : 

node_modules/portfinder/lib/portfinder.d.ts:39:1 - error TS1128: Declaration or statement expected.

39 export setBasePort(port: number);
   ~~~~~~

node_modules/portfinder/lib/portfinder.d.ts:39:24 - error TS1005: ',' expected.

39 export setBasePort(port: number);
                          ~

node_modules/portfinder/lib/portfinder.d.ts:49:1 - error TS1128: Declaration or statement expected.

49 export setHighestPort(port: number);
   ~~~~~~

node_modules/portfinder/lib/portfinder.d.ts:49:27 - error TS1005: ',' expected.

49 export setHighestPort(port: number);
                             ~
lelikg commented 2 years ago

+1 having the same issue 

node_modules/portfinder/lib/portfinder.d.ts(39,1): error TS1128: Declaration or statement expected.
node_modules/portfinder/lib/portfinder.d.ts(39,24): error TS1005: ',' expected.
node_modules/portfinder/lib/portfinder.d.ts(49,1): error TS1128: Declaration or statement expected.
node_modules/portfinder/lib/portfinder.d.ts(49,27): error TS1005: ',' expected.
npm ERR! code 2
jonluca commented 2 years ago

Fixed in https://github.com/http-party/node-portfinder/pull/139

eriktrom commented 2 years ago

Taking a look, thanks, sorry was out last week

eriktrom commented 2 years ago

fixed by #141

release scheduled for this morning