http-rs / http-types

Common types for HTTP operations
https://docs.rs/http-types
Apache License 2.0
200 stars 83 forks source link

Fix Accept header sort order #361 #390

Closed u5surf closed 2 years ago

u5surf commented 2 years ago

Fixes: #361

yoshuawuyts commented 2 years ago

Thanks for opening this PR! On reviewing the spec, you're indeed right that our current implementation is not compliant - but this PR doesn't implement the ordering dictated by the spec either.

I've written an analysis of the issues we have in our content negotiation in https://github.com/http-rs/http-types/issues/361#issuecomment-1008872107, and my hope is that we can use that to implement a spec-compliant fix.

I'm going to close this PR for now since it doesn't match the spec. But I'd be keen to review any follow-up PRs which help bring our content-negotiation implementation according to spec. Thanks!