Only add the parameters to the parameters map if they have a name - Githubissues

http-rs / route-recognizer

Recognizes URL patterns with support for dynamic and wildcard segments

MIT License

100 stars 38 forks source link

Only add the parameters to the parameters map if they have a name #31

Closed gameldar closed 5 years ago

gameldar commented 5 years ago

Closes #29 by only adding named parameters to the parameter map

Description

If the capture has an empty string for a name then don't add it to the map

Motivation and Context

Closes #29 Note this is technically a breaking change as before you could actually query for the parameter with an empty string.

How Has This Been Tested?

Unit tests have been implemented to ensure the intended behaviour

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.