search

http-rs / surf

Fast and friendly HTTP client framework for async Rust
https://docs.rs/surf
Apache License 2.0
1.46k stars 120 forks source link

Fix set header #187

Closed Licenser closed 4 years ago

Licenser commented 4 years ago

This fixes #183 - a panic set-header in 0.3. The issue was that set_header calls unwrap() on the option returned by insert_header, which only returns a Some if a header already existed.

Licenser commented 4 years ago

@yoshuawuyts any chance to fast track this fix since the underlying bug makes alpha.3 unusable when headers are involved?

yoshuawuyts commented 4 years ago

I'll try and get a release for this in on Friday.

Licenser commented 4 years ago

Thank you! <3

yoshuawuyts commented 4 years ago

published!

Licenser commented 4 years ago

Thank you so much for the quick handling!!