http-rs / surf

Fast and friendly HTTP client framework for async Rust
https://docs.rs/surf
Apache License 2.0
1.46k stars 119 forks source link

TryFrom to From for surf::Request #190

Closed mainrs closed 4 years ago

mainrs commented 4 years ago

The current implementation of TryFrom succeeds 100% of the time, meaning that it can be safely re-written as a From implementation. This was mentioned in #170.

This is, however, a breaking change.

mainrs commented 4 years ago

Kind a of mess at the end, I accidentally accepted the wrong changes and noticed that too late! A squash would be a good idea :smile: