search

http-rs / surf

Fast and friendly HTTP client framework for async Rust
https://docs.rs/surf
Apache License 2.0
1.46k stars 119 forks source link

Rename main branch to `main`? #211

Closed zkat closed 4 years ago

zkat commented 4 years ago

What do y'all think? Plz no trolls

goto-bus-stop commented 4 years ago

Maybe we can run https://github.com/mheap/github-default-branch for the entire http-rs org?

yoshuawuyts commented 4 years ago

Yep, let's do it! I believe GitHub will soon release tools to make this transition easy, but if folks want to move ahead before that we can as well!

Fishrock123 commented 4 years ago

Yeah I was thinking about this as well, I don't have any objections.

Though I do wish github had chosen "trunk", oh well.

goto-bus-stop commented 4 years ago

I can do this tomorrow. We'll also need to update a bunch of references to the branch name, but it looks like that's just in readmes and not in things like action configs, so not super high stakes stuff.

One potentially annoying thing for end users is that Cargo uses the master branch for git dependencies by default regardless of what we configure in Github. So if folks are doing things like surf = { git = "https://github.com/http-rs/surf.git" } that will break. Then again if you're depending on a branch and not a particular commit you can expect to get breaking changes without warning, and this is just one of them 😇

zkat commented 4 years ago

Cargo should tbh probably be patched so that it uses the remote HEAD, tbh. That seems like a pretty bad Cargo bug.

goto-bus-stop commented 4 years ago

It looks like that behaviour was recently changed: https://github.com/rust-lang/cargo/pull/8364 So maybe what I said isn't true anymore? I'm not sure if that PR is in a Rust release already.

goto-bus-stop commented 4 years ago

^ that should be all of them!