http-rs / surf

Fast and friendly HTTP client framework for async Rust
https://docs.rs/surf
Apache License 2.0
1.45k stars 119 forks source link

Replace the native-client feature flag in client.rs and request.rs with its component features #214

Closed rossdylan closed 4 years ago

rossdylan commented 4 years ago

Previously it was not possible to compile surf with just curl enabled. This was caused by the usage of the native-client feature which by default includes both curl and wasm backends. This change alters the cfg options to gate on either wasm-client or curl-client.

A companion PR in http-client (https://github.com/http-rs/http-client/pull/34) is required to completely fix curl only compilation.

Fishrock123 commented 4 years ago

This seems correct to me.