http-rs / surf

Fast and friendly HTTP client framework for async Rust
https://docs.rs/surf
Apache License 2.0
1.45k stars 119 forks source link

forbidding 2018 idioms Incompatible with pin_project_lite 0.1.9 #244

Closed rbtcollins closed 3 years ago

rbtcollins commented 3 years ago
Updating pin-project-lite v0.1.8 -> v0.1.9

lead to:

error[E0453]: allow(explicit_outlives_requirements) overruled by outer forbid(rust_2018_idioms)
  --> /home/robertc/.cargo/registry/src/github.com-1ecc6299db9ec823/surf-2.0.0-alpha.6/src/response.rs:17:1
   |
17 | / pin_project_lite::pin_project! {
18 | |     /// An HTTP response, returned by `Request`.
19 | |     pub struct Response {
20 | |         #[pin]
21 | |         res: http_client::Response,
22 | |     }
23 | | }
   | |_^ overruled by previous forbid
   | 
  ::: /home/robertc/.cargo/registry/src/github.com-1ecc6299db9ec823/surf-2.0.0-alpha.6/src/lib.rs:73:11
   |
73 |   #![forbid(rust_2018_idioms)]
   |             ---------------- `forbid` level set here
   |
   = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for more info)

error: aborting due to previous error

For more information about this error, try `rustc --explain E0453`.
error: could not compile `surf`.

To learn more, run the command again with --verbose.

pinning pin-project-lite back to 0.1.8 allows everything to build again.

Licenser commented 3 years ago

Could we get an alpha.7 with this merged?

jbr commented 3 years ago

@Licenser 👍 alpha.7 released

Licenser commented 3 years ago

<3 thank you @jbr !