search

http-rs / surf

Fast and friendly HTTP client framework for async Rust
https://docs.rs/surf
Apache License 2.0
1.45k stars 119 forks source link

Please support http-client's new h1_client_rustls feature #272

Closed joshtriplett closed 3 years ago

joshtriplett commented 3 years ago

I'd like to use surf with http-client's new h1_client_rustls feature, so I can avoid openssl. Please consider plumbing that option through as a surf backend feature.

djarb commented 3 years ago

Seconded, thank you.

Fishrock123 commented 3 years ago

https://github.com/http-rs/surf/pull/271 exists but I am not really sure what the best way to design these feature flags is. Would "h1-rustls-client" be suitable?

djarb commented 3 years ago

That would satisfy my needs

Fishrock123 commented 3 years ago

Further discussion exists in https://github.com/http-rs/surf/pull/271#issuecomment-762535474

I also need this for https://github.com/nlopes/libhoney-rust/pull/61

The question is how can the feature flags be structured in a "nice" way. I am not super happy with the http-client h1_client_rustls flag, which is why I had not yet released it. But also, I am not sure if there is presently an alternative since we essentially have a matrix of client+tls feature functionality, and weak dependency features have not yet stabilized.

joshtriplett commented 3 years ago

This seems to be working in the released surf, at this point. While the structure of the feature flags could potentially change in the future, I think this issue as reported has been addressed.

Thank you!