search

http-rs / surf

Fast and friendly HTTP client framework for async Rust
https://docs.rs/surf
Apache License 2.0
1.45k stars 119 forks source link

Wrong config for feature? #326

Closed aadi-pcln closed 2 years ago

aadi-pcln commented 2 years ago

Hi Folks,

First, thank you for making Surf. It's really been quite a pleasure to use.

I believe I've discovered an error in feature configuration, when I was trying to get at the set_tls_config function while trying to use the h1-client with native-tls support.

It looks like the feature configuration is mistyped as h1_client when all other references are h1-client. Happy to open a PR but I wanted to confirm this was an actual issue and not intentional.

Please see here: https://github.com/http-rs/surf/blob/main/src/config.rs#L206

Thanks!

Fishrock123 commented 2 years ago

@aadi-pcln please submit a PR and I will make a release

Fishrock123 commented 2 years ago

Fixed by https://github.com/http-rs/surf/pull/327 ... release still todo

Fishrock123 commented 2 years ago

Released 2.3.2 https://github.com/http-rs/surf/releases/tag/v2.3.2