search

http-rs / tide

Fast and friendly HTTP server framework for async Rust
https://docs.rs/tide
Apache License 2.0
5.07k stars 321 forks source link

Set `TCP_NODELAY` on the `TcpStream` to disable Nagle's algorithm. #900

Closed kyrias closed 1 year ago

kyrias commented 2 years ago

Due to the way the async-h1 crate writes HTTP responses to the TcpStream the head and body end up in separate write calls to the underlying socket. If we're responding to more than one request received from the same TcpStream it means that we did two sends and then tried to read. That read can take up to 500 milliseconds to complete due to bad interactions between Nagle's algorithm and delayed ACK. (In practice this is 40 ms on Linux.)

Disabling Nagle's algorithm works around this until async-h1 is fixed.

https://github.com/http-rs/async-h1/issues/199

kyrias commented 1 year ago

Finally got around to figuring out how to fix this properly in async-h1. C.f. http-rs/async-h1#200