http4s / blaze

Blazing fast NIO microframework and Http Parser
Apache License 2.0
351 stars 63 forks source link

Implement Connection persistence per RFC 9112, Section 9.3 #913

Closed rossabaker closed 1 month ago

rossabaker commented 1 month ago

We are aggressively closing connections in the presence of Connection headers composed exclusively of options other than keep-alive or close. This is contrary to the RFC

milessabin commented 1 month ago

LGTM.

Maybe a bit off-topic for this PR, but when returning a Connection: close do you pause before closing to allow the client to do an active close avoiding TIME_WAIT on the server side?

rossabaker commented 1 month ago

Hell, I started from the wrong branch.

rossabaker commented 1 month ago

Miles has a good question that I haven't dug into yet. Spinning that off into an issue.