search

http4s / http4s-grpc

https://http4s.github.io/http4s-grpc/
MIT License
37 stars 3 forks source link

Don't prefix `_root_` when referring to scala type #72

Open armanbilge opened 8 months ago

armanbilge commented 8 months ago

The official ScalaPB generator does not do this. https://github.com/scalapb/ScalaPB/blob/f20940a2fc70c5f7d457000612b5173de0ed1f40/compiler-plugin/src/main/scala/scalapb/compiler/GrpcServicePrinter.scala#L31

Fixes https://github.com/davenverse/http4s-grpc/issues/70.

danicheg commented 1 month ago

@armanbilge hey! what does stop us from merging this?

armanbilge commented 1 month ago

I wrote some comments in https://github.com/http4s/http4s-grpc/issues/70#issuecomment-1774849417. I think I realized that this fix is broken.

danicheg commented 1 month ago

Ah, I see.