search

http4s / http4s-servlet

http4s-servlet support
Apache License 2.0
6 stars 5 forks source link

New AsyncHttp4sServlet builder doesn't have `serviceErrorHandler` #160

Open dhinojosa opened 1 year ago

dhinojosa commented 1 year ago

AsyncHttp4sServlet from a discussion with Ross seems to be missing serviceErrorHandler. Not sure if it should be included or not, but I added a ticket just in case.

Here is what methods are included currently.

AsyncHttp4sServlet
          .builder(httpApp, dispatcher)
          .withAsyncTimeout(builder.asyncTimeout)
          .withChunkSize(chunkSize)
          .build
rossabaker commented 1 year ago

I argue it shouldn't: a middleware achieves the same end, and applies to all httpApp (it's just functions!) instead of needing to be maintained on each backend.