search

http4s / http4s-servlet

http4s-servlet support
Apache License 2.0
6 stars 5 forks source link

Upgrade to http4s-0.23.19 #197

Closed rossabaker closed 1 year ago

rossabaker commented 1 year ago

Backport #194, which should have targeted this branch. This fixes the cancellation semantics of cats-effect-3.5.

rossabaker commented 1 year ago

This has failed a few times, and I'm too sleepy to figure it out tonight:

==> X org.http4s.servlet.RouterInServletSuite.Http4s servlet should handle alternative-root request  30.005s java.util.concurrent.TimeoutException: Future timed out after [30 seconds]
    at scala.concurrent.impl.Promise$DefaultPromise.tryAwait0(Promise.scala:248)
    at scala.concurrent.impl.Promise$DefaultPromise.result(Promise.scala:261)
    at scala.concurrent.Await$.$anonfun$result$1(package.scala:201)
    at cats.effect.unsafe.WorkerThread.blockOn(WorkerThread.scala:835)
    at scala.concurrent.Await$.result(package.scala:124)
    at munit.internal.PlatformCompat$.$anonfun$waitAtMost$1(PlatformCompat.scala:21)
    at scala.util.Try$.apply(Try.scala:210)
    at munit.internal.PlatformCompat$.waitAtMost(PlatformCompat.scala:21)
    at munit.FunSuite.waitForCompletion(FunSuite.scala:51)
    at munit.FunSuite.$anonfun$test$1(FunSuite.scala:37)
    at munit.MUnitRunner.$anonfun$runTestBody$1(MUnitRunner.scala:296)
rossabaker commented 1 year ago

This ran safely three times. I'm declaring victory.