httpdispatch / MissedNotificationsReminder

Periodical sound reminder for missed notifications in Android OS.
74 stars 22 forks source link

Don't vibrate if phone is in Silent Mode. + some suggestion #12

Closed jsximes closed 8 years ago

jsximes commented 8 years ago

I made a small patch so the Reminder won't vibrate if the phone is in silent mode. It is attached in the link below.

Using code from http://stackoverflow.com/questions/2048427/how-can-i-detect-whether-the-android-phone-in-silent-mode-programatically

The app is great! I hope to see it soon definitely added to the android.

Also I would make a suggestion about customization of the scheduler. My Cyanogenmod android kit-kat already have a programmable scheduler (called Quiet Hours) to set to enter silent mode, vibration only, turn off the notification led, and many other behaviours on programmable times (however not by day-of-the-week). My guess is that such scheduler improvements should not be done in this app... so won't override the android features... I think rarely someone will need a different behaviour for each app/time/day/reminder notif./app notification/vibrate/led/sound....

Thanks!!!

0001-Dont-vibrate-if-phone-is-is-Silent-Mode.patch.txt

httpdispatch commented 8 years ago

Thank You for the patch. I will try to apply it with some modifications in the nearest future. I think the app should stop schedule new reminders for the cases when ringer mode is changed to RINGER_MODE_SILENT until ringer mode is not changed back to some noisy one . This will allow to do not wake device periodically for no reason and reduce battery usage.

I agree regarding scheduler modification: that will be the very big update for such a small tool.

httpdispatch commented 8 years ago

Added. Thanks for your contribution