httpdispatch / MissedNotificationsReminder

Periodical sound reminder for missed notifications in Android OS.
74 stars 22 forks source link

Add settings for number of reminder repetitions and implement this feature #22

Closed rryk closed 6 years ago

rryk commented 7 years ago

This also renames Reminder Interval section into Reminder Settings and changes names of corresponding classes and files.

httpdispatch commented 7 years ago

Thank you very much for the pull request. The limit number of repeats feature has been requested many times so users should be happy with it. I'll try to find a time to review, merge and test pull request and release new version in the next week.

rryk commented 7 years ago

Thanks. I have another feature in the pipeline coming after this, but not sure how to add it to a separate pull request... if I push it to master it gets automatically added to this, so I've pushed it into another branch. Once this is merged, I'll push it to master and create another pull request.

The feature is about creating a dismiss notification whenever the reminder is active. When enabled, it allows users to disable reminders without dismissing the original notification. Here is diff if you are curious: https://github.com/rryk/MissedNotificationsReminder/compare/master...dismiss.

rryk commented 7 years ago

This change will address https://github.com/httpdispatch/MissedNotificationsReminder/issues/9.

httpdispatch commented 6 years ago

Released the implemented feature. Thank you very much for the contribution. Only one minor fix has been applied https://github.com/httpdispatch/MissedNotificationsReminder/commit/7a6b1ebe3a87d1b9c65ec4f2f90a0980a0be1f70

rryk commented 6 years ago

Awesome. Thanks.