search

httpie / cli

🥧 HTTPie CLI — modern, user-friendly command-line HTTP client for the API era. JSON support, colors, sessions, downloads, plugins & more.
https://httpie.io
BSD 3-Clause "New" or "Revised" License
32.7k stars 3.67k forks source link

Remove unnecessary process wait on MacOS (issue #1523) #1526

Open cedel1 opened 10 months ago

cedel1 commented 10 months ago

Remove process.communicate() in MacOS causing wait for subprocess even when the subprocess results were not used.

cedel1 commented 10 months ago

Hmm, I am surprised by the unrelated codecov check failure (especially since that part wasn't changed for quite some time, it fails on master and tests in previous PRs passed. Version changes?

codecov-commenter commented 10 months ago

Codecov Report

Patch coverage is 89.91% of modified lines.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Files Changed Coverage
httpie/output/ui/man_pages.py 0.00%
httpie/output/ui/rich_utils.py 0.00%
tests/test_binary.py ø
tests/test_defaults.py ø
tests/test_output.py ø
tests/test_parser_schema.py ø
tests/test_plugins_cli.py ø
tests/test_redirects.py ø
tests/test_regressions.py ø
tests/test_sessions.py ø
... and 90 more

:loudspeaker: Thoughts on this report? Let us know!.