search

httpie / httpie-aws-auth

AWS / Amazon S3 auth plugin for HTTPie
https://httpie.org
Other
38 stars 12 forks source link

httpie dependency not pinned #5

Open vbhavsar opened 2 years ago

vbhavsar commented 2 years ago

httpie dependency is defined as https://github.com/httpie/httpie-aws-auth/blob/bc2435ce248d0b593a602dbb3e3cf647183b7a3a/setup.py#L26

httpie is now at 2.6.0 and many things have changed since 0.9.7. This causes issues such as #3.

There is another compatibility issue. This import also doesn't exist in 2.6.0 https://github.com/httpie/httpie-aws-auth/blob/bc2435ce248d0b593a602dbb3e3cf647183b7a3a/httpie_aws_auth.py#L10

I believe the right way to fix this is to pin the dependency to a specific version (or a range of known good versions).

m9aertner commented 1 year ago

I ran into that second issue as well

from httpie.compat import bytes

I think that line can just be removed.