httprb / http

HTTP (The Gem! a.k.a. http.rb) - a fast Ruby HTTP client with a chainable API, streaming support, and timeouts
MIT License
3.01k stars 321 forks source link

Handle connection timeouts in Features #656

Closed semenyukdmitry closed 3 years ago

semenyukdmitry commented 3 years ago

The change from 609f07b3454bde2f48ca5e1589cda169f7a77187 allows Features to handle errors, but it isn’t a complete implementation, because while it does handle read/write timeouts, it does not work for connection timeouts.

This pull request resolves this by moving connection establishment to the exception-handling block introduced in that commit.

ixti commented 3 years ago

Thank you!