search

httprb / http

HTTP (The Gem! a.k.a. http.rb) - a fast Ruby HTTP client with a chainable API, streaming support, and timeouts
MIT License
3.01k stars 321 forks source link

HTTP status 1xx responses (Continue) are not supported #667

Open jrnk opened 3 years ago

jrnk commented 3 years ago

See issue #593 and #592 , this issue is still present in the 5.0 release

This code should be in the 5.0 release (from the release notes), but it's missing:

See f.e. on_message_complete on that supposedly merged commit https://github.com/httprb/http/blob/46a52dcf0bb891ccddfe49413c93bc5be295fcf9/lib/http/response/parser.rb#L88

And the one in the 5.0 release: https://github.com/httprb/http/blob/v5.0.0/lib/http/response/parser.rb#L114

tarcieri commented 3 years ago

@ixti was this reverted?

ixti commented 3 years ago

https://github.com/httprb/http/pull/651 introduced the regression. Will work on this.