feature: Restore HTTP::Response :uri option for backwards compatibility. - Githubissues

httprb / http

HTTP (The Gem! a.k.a. http.rb) - a fast Ruby HTTP client with a chainable API, streaming support, and timeouts

MIT License

3.01k stars 321 forks source link

feature: Restore HTTP::Response :uri option for backwards compatibility. #678

Closed schwern closed 3 years ago

schwern commented 3 years ago

This should allow folks to update to 5.x without breaking code, in my case test factories, which make HTTP::Responses.

If nothing else, the current code has the potential for response.uri and response.request.uri to be different and that seems Bad.

Put :uri back, but its deprecated. Remove it in 6.x?
:uri and :request now conflict to avoid having uri being one thing and request.uri another.
- Could allow it if uri and request.uri.to_s match?
- Is supplying both useful for forward compatibility?
Remove redundant internal uses of uri.