httprb / http

HTTP (The Gem! a.k.a. http.rb) - a fast Ruby HTTP client with a chainable API, streaming support, and timeouts
MIT License
3.01k stars 321 forks source link

Unable to log or instrument redirects #681

Closed nomis closed 3 years ago

nomis commented 3 years ago

I'm using instrumentation to validate the URI being requested (to restrict it to specific schemes/ports) and raise an error if it's not allowed.

This doesn't work on redirects because features that wrap the request are not (as of v4.4.1) applied to redirected requests.

I've created PRs to fix this: #679 and #680.

tarcieri commented 3 years ago

Merged both PRs. Closing this.