httprb / http

HTTP (The Gem! a.k.a. http.rb) - a fast Ruby HTTP client with a chainable API, streaming support, and timeouts
MIT License
3.01k stars 321 forks source link

Fix the pinning of Rubocop version #716

Closed drwl closed 2 years ago

drwl commented 2 years ago

This PR pins Rubocop to the last version that's supported by Ruby 2.5. I think it was improperly pinned/Rubocop's versioning went different than expected.

Some PRs are experiencing unrelated linting issues. I don't have the context to safely make these changes, but this change should unblock folks.

drwl commented 2 years ago

It's not clear why the lint step is failing:

https://github.com/httprb/http/runs/6890611978?check_suite_focus=true

Run bundle exec rubocop --format progress --color
Your RubyGems version (2.7.6.3) has a bug that prevents `required_ruby_version` from working for Bundler. Any scripts that use `gem install bundler` will break as soon as Bundler drops support for your Ruby version. Please upgrade RubyGems to avoid future breakage and silence this warning by running `gem update --system 3.2.3`
Error: unrecognized cop or department Gemspec/DeprecatedAttributeAssignment found in .rubocop_todo.yml
Did you mean `Gemspec/OrderedDependencies`?
Error: Process completed with exit code 2.

Locally this passes for me

➜  httprb-gem git:(drwl/fix-rubocop-issues) ✗ bundle exec rubocop --format progress --color
Inspecting 80 files
................................................................................

80 files inspected, no offenses detected
drwl commented 2 years ago

@tarcieri I'm not able to request reviewers, but this should fix the failed linting step in various PRs.

drwl commented 2 years ago

cc @ixti

tarcieri commented 2 years ago

Thanks!

ixti commented 2 years ago

LOL I guess I'm too late for the review :D