search

httprb / http

HTTP (The Gem! a.k.a. http.rb) - a fast Ruby HTTP client with a chainable API, streaming support, and timeouts
MIT License
3.01k stars 321 forks source link

Add JRUBY to CI #720

Closed ixti closed 2 years ago

ixti commented 2 years ago

@tarcieri should we maintain JRuby support? It's holding us from bumping up min ruby version to 2.6

tarcieri commented 2 years ago

@ixti you could always do something like:

gem.required_ruby_version = defined?(JRUBY_VERSION) ? "2.5" : "2.6"
ixti commented 2 years ago

@tarcieri I think it will cause weird bugs, eventually. :D For example if we will use beginless ranges. And as JRuby historically was false-failing in this repo - chances that bug will sneak are pretty high.

Also, I've mistyped I meant bump version to Ruby 2.7. :D

tarcieri commented 2 years ago

Aah. I imagine there are a number of JRuby users of this library still (indeed that's probably still true of a few of my former employers).

Unless there's a big benefit to dropping support, I suggest we continue to do so.

ixti commented 2 years ago

There are some benefits, but most of them are in my head then real world. ))) If jruby is used by the http gem consumers then let's keep it )))

ixti commented 2 years ago

Will need to fix CI then ))) or mark some tests as non jruby friendly )))

ixti commented 2 years ago

@tarcieri I've added JRuby into "flaky specs group" for now. because re-running individual failing specs works just fine. Which means there might be some state related issue thuogh :((