https-deeplearning-ai / machine-learning-engineering-for-production-public

Public repo for DeepLearning.AI MLEP Specialization
Apache License 2.0
1.85k stars 2.36k forks source link

Fix naming of parameters in conlist type function from pydantic #109

Closed JackismyShephard closed 11 months ago

JackismyShephard commented 11 months ago

This pull request addresses an issue found in the main.py file located at /course4/week2-ungraded-labs/C4_W2_Lab_1_FastAPI_Docker/with-batch/app.

The problem was due to applying the conlist type function from Pydantic with the wrong naming of two keyword arguments. The two keyword arguments were incorrectly named min_items and max_items but the correct names are respectively min_length and max_length.

cfav-dev commented 11 months ago

Hi! Thank you for reporting! As of now, we're not accepting PRs but the issue is now fixed. Thanks again!