search

httptoolkit / brotli-wasm

A reliable compressor and decompressor for Brotli, supporting node & browsers via wasm
Apache License 2.0
260 stars 19 forks source link

Add benchmark #5

Open yisibl opened 2 years ago

yisibl commented 2 years ago

Benchmark helps us better understand how to choose between similar libraries.

Thanks!

pimterry commented 2 years ago

I'm not likely to be able to do this myself any time soon, but I would happily accept PRs adding benchmark data (along with the scripts used) if you or anybody else is interested in that.

yisibl commented 2 years ago

I added the benchmark here, but brotli-wasm reported an error. https://github.com/yisibl/brotli-js/blob/c89ae193a882dbafcf3372f2c42fb65a376845e6/benchmark/bench.ts#L59-L61

pimterry commented 2 years ago

Can you share the error that you're seeing from brotli-wasm? In your CI logs, it looks like everything passes on all platforms except i686-pc-windows-msvc, and the only error there is:

× test\index.spec.ts exited with a non-zero exit code: 3221225477

I can't see anything about brotli-wasm itself in there.