search

httptoolkit / httptoolkit-android

Automatic Android interception & debugging with HTTP Toolkit, for Android
https://httptoolkit.com
GNU Affero General Public License v3.0
493 stars 77 forks source link

Specific apps feature added #1

Closed AmniX closed 4 years ago

AmniX commented 4 years ago

Hi, I have added feature to select packages so user can Intercept selected packages only.

I required it for myself, But I would like to contribute this too.

Some Screenshots are below.

image image

AmniX commented 4 years ago

Travis CI Failed Because of Below Error. The command "openssl aes-256-cbc -K $encrypted_410c058128c0_key -iv $encrypted_410c058128c0_iv -in android-travis-cert-store.enc -out ./android-travis-cert-store.jks -d" failed and exited with 1 during .

pimterry commented 4 years ago

Amazing! This looks really good, great work. Everything's a little hectic now so it's going to take me a couple of days to get time to properly dig into this and test it out, but it looks pretty solid from a quick skim.

Don't worry about the Travis error. It's complaining because PRs can't read the env var secrets used on the master build. I should tidy that up really, but for now you can just ignore it.

Have you seen the Free As In Beer policy? In short, contributors get free HTTP Toolkit Pro. I'll sort that out once I've reviewed this and merged it, but do let me know what email address you want your account linked to once this is done - just send me an email to tim@httptoolkit.tech.

AmniX commented 4 years ago

Thank you so much for In Depth Code Review and Suggestions.

Will Implement over the weekend.

pimterry commented 4 years ago

Hi @AmniX, any update on this? No problem if you don't have time, I can dig into it myself, just let me know.

AmniX commented 4 years ago

Yes Please Go ahead. Busy in some office work which is super big that i even working on weekends.

CLAassistant commented 4 years ago

CLA assistant check
All committers have signed the CLA.

pimterry commented 4 years ago

I'm just getting around to finishing this myself now, so I'm just rebasing it and handling my comments now, and then I'll merge this shortly.

@AmniX, sorry for the delay, and thanks again for this contribution! Are you still interested in the free Pro account? Send me an email to tim@httptoolkit.tech and I can get set you up straight away if so.

I've also activated the licensing check on this repo, that should've been here before - when you get a sec, can you go to https://cla-assistant.io/httptoolkit/httptoolkit-android?pullRequest=1, log in with your github account, and accept the agreement there? Just takes two clicks, it's just a matter of confirming that you do have the rights to contribute this code, and agreeing to give the rights to use this contribution to the HTTP Toolkit project. The challenges of an open-source business :smile: