Improve layout avoid covering the buttons on low resolution devices

httptoolkit / httptoolkit-android

Automatic Android interception & debugging with HTTP Toolkit, for Android

https://httptoolkit.com

GNU Affero General Public License v3.0

476 stars 72 forks source link

Improve layout avoid covering the buttons on low resolution devices #20

Closed kaisar945 closed 5 months ago

kaisar945 commented 6 months ago

Before
After

CLAassistant commented 6 months ago

All committers have signed the CLA.

pimterry commented 6 months ago

Oh, interesting! Thanks for the contribution @kaisar945, excellent point.

I do agree this is better than the current behaviour here where the buttons disappear, although it would be nice if there was no need to scroll, and we do have some unnecessary whitespace left here...

Do you think it's easy to shrink the whitespace (e.g. above the Connected text) just on small screens, to help with this? I think we'd want to use the scrollview too just as a backup for really small cases, but it would be nice to avoid needing that where possible.

Out of interest, what device are you using where you're seeing this, and what's the resolution? I thought I'd tested most common small sizes, but this is clearly smaller than I was expecting.

kaisar945 commented 6 months ago

Thank you for your reply, you are right I will try it.

This is my device resolution, it's not a real phone

Physical size: 480x960 Physical density: 240

pimterry commented 5 months ago

I'm still interested in this! Do you think you'll have any time soon to investigate tweaking the whitespace here?

kaisar945 commented 5 months ago

Of course， I've been busy with work recently and almost forgot about this. I'll take some time to fix it as soon as possible.

kaisar945 commented 5 months ago

Updated.

pimterry commented 5 months ago

Thanks @kaisar945! Merged and released as v1.3.11 (building now, it'll be live on Google Play and auto-downloaded in HTTP Toolkit within a day or so)

pimterry commented 5 months ago

By the way, in case you're not aware, HTTP Toolkit Pro is free for contributors - I've set up an account linked to your Git commit email (j.j@gmail.com). Just click 'Get Pro' then 'Log into existing account' and enter your email there to log in. Thanks again!

kaisar945 commented 5 months ago

By the way, in case you're not aware, HTTP Toolkit Pro is free for contributors - I've set up an account linked to your Git commit email (j.j@gmail.com). Just click 'Get Pro' then 'Log into existing account' and enter your email there to log in. Thanks again!

Thank you for providing a powerful tool😃