Auto Hide Menu Bar Settings

httptoolkit / httptoolkit-desktop

Electron wrapper to build and distribute HTTP Toolkit for the desktop

https://httptoolkit.com

GNU Affero General Public License v3.0

593 stars 81 forks source link

Auto Hide Menu Bar Settings #28

Closed shirshak55 closed 2 years ago

shirshak55 commented 2 years ago

This PR gives ability to hide menubar. I have never used them and I think many users will never use them too.

Users can always press Alt to reveal those menus just like in firefox or vscode.

Maybe it is better to document in the HTTP toolkit website. Also maybe we can add it in the settings of the renderer process.

For future:

Before: Screenshot from 2021-07-29 08-47-22

After: Screenshot from 2021-07-29 08-47-18

shirshak55 commented 2 years ago

I don't know how we persist in settings. May be its time to use basic setting storage like electron store?

pimterry commented 2 years ago

Thanks! I've done some testing and tweaked it a little:

I've refactored the structure of the previously existing menu into a function. That allows us to move all of the logic related to this functionality into the menu file (to avoid an index <-> menu circular dependency) and should make it easier to manage and extend the menu for other features in future.
There was a small bug, because checked wasn't set, so the menu option didn't show as checked at startup even if it was enabled, and the first click after startup wouldn't disable it.
I've hidden it on Mac, because it doesn't make sense (the menu bar is always visible as part of the OS UI) and so APIs like setMenuBarVisibility are only supported on Linux & Windows.

Otherwise I think this is a nice little improvement, thanks! Merging now :+1:

shirshak55 commented 2 years ago

@pimterry how are updates distributed. I downloaded HTTP toolkit to see that option but I can't find it.

pimterry commented 2 years ago

It's not published yet. At some point soon I'll bump the version to create a new release, then manually test the resulting builds on every platform to make sure nothing's broken, then update the version that's used for download on the web site here.

If you want to use it yourself ASAP in the meantime you can download complete builds directly from every CI build, there's separate linux, mac & windows distributable zips attached to all of them, for example: https://github.com/httptoolkit/httptoolkit-desktop/actions/runs/1090764188

shirshak55 commented 2 years ago

thanks :) I see it requires release tags.

pimterry commented 2 years ago

Just to let you know, this is now released as v1.4.4, available from releases here but also as the new latest version on httptoolkit.tech. Thanks again for contributing this great feature!