search

httptoolkit / httptoolkit-desktop

Electron wrapper to build and distribute HTTP Toolkit for the desktop
https://httptoolkit.com
GNU Affero General Public License v3.0
615 stars 83 forks source link

Building Issue Ubuntu 22.04 (improvement) #48

Open neil-yoga-crypto opened 2 years ago

neil-yoga-crypto commented 2 years ago

Thank you for making this tool!

Just a small thing, after downloading all the files, I received this message on my Ubuntu 22.04 machine:

"⨯ to build rpm, executable rpmbuild is required, please install: sudo apt-get install rpm"

It would be nice to check the dependencies before downloading everything.

pimterry commented 2 years ago

Oooh, good suggestion! By 'downloading all the files', you mean the server download step?

If you want to open a PR to add a check step before that, that would be very welcome, sure! It would be best to add that as another npm script here, maybe check-dependencies or similar, and then running that step as part of the existing build:electron step. That step can just run a TS script like server:setup does, and implementing whatever checks are required there.

I would suggest taking a look at the code for Electron Builder to find exactly how they do this rpmbuild check (and what else they check for) just to make sure the logic is the same.

neil-yoga-crypto commented 2 years ago

Thanks. It's after I run npm run build, which cause many things such as Electron to download.