httptoolkit / httptoolkit-desktop

Electron wrapper to build and distribute HTTP Toolkit for the desktop
https://httptoolkit.com
GNU Affero General Public License v3.0
593 stars 81 forks source link

HTML markup showing up in the Debian installer #58

Closed thesurlydev closed 1 year ago

thesurlydev commented 1 year ago

I noticed there's HTML markup showing in the title for the Debian installer.

httptoolkit-issue

pimterry commented 1 year ago

Huh, that's very interesting. Thanks for letting me know! I'll look into it.

thesurlydev commented 1 year ago

Forgot to mention this is on Pop OS 22.04 if that factors in

pimterry commented 1 year ago

I did some more digging, I actually have no idea where this is coming from. I've extracted the contents of the latest package manually with dpkg-deb -R <pkg> . and examining the metadata shows:

Package: httptoolkit
Version: 1.12.6
License: AGPL-3.0-or-later
Vendor: contact@httptoolkit.tech
Architecture: amd64
Maintainer: contact@httptoolkit.tech
Installed-Size: 375997
Depends: libgtk-3-0, libnotify4, libnss3, libxss1, libxtst6, xdg-utils, libatspi2.0-0, libuuid1, libsecret-1-0
Recommends: libappindicator3-1
Section: default
Priority: optional
Homepage: https://httptoolkit.tech
Description: 
  HTTP(S) debugging, development & testing tool

So the <b>...</b> isn't actually present at all. I've also opened the package with gdebi, and it appears correctly there with no problems - this only appears with Eddy (which I've just installed specifically to reproduce this). Is it possible that Eddy is adding this somewhere for some reason? Do you see this with other packages? I don't know much about Eddy at all.

thesurlydev commented 1 year ago

I haven't seen the issue otherwise but I'm also told I'm not observant 😀

I took a quick look on eddy and PopOS repos to see if it's been reported but didn't find anything.

pimterry commented 1 year ago

Ok, I'll file an issue with Eddy and see if they know what's up here.

pimterry commented 1 year ago

This was indeed an Eddy bug, triggered by the & in the description here (which is valid, but seems to have broke some parsing). It's now been fixed in https://github.com/donadigo/eddy/pull/136.

Thanks for reporting this! Glad we could get that sorted out :smile: