search

httptoolkit / httptoolkit-server

The backend of HTTP Toolkit
https://httptoolkit.com
GNU Affero General Public License v3.0
459 stars 101 forks source link

added firefox developer support #118

Closed xKiian closed 5 months ago

xKiian commented 6 months ago

#555

xKiian commented 6 months ago

i can only test the changes on windows 11 sadly

pimterry commented 6 months ago

i can only test the changes on windows 11 sadly

No problem, that's fine! It'll need to wait until I'm back in my office next week, but I can properly test both Linux & Mac there no problem, so that will cover everything. Once all the other changes are done here and the tests are passing I think this is OK to merge anyway, any detection issues can be fixed elsewhere later.

xKiian commented 6 months ago

but detection particularly has a few platform specific bits, so I'll need to test any cases you haven't covered before we ship this.

I didn't change the functionality for the detection.

pimterry commented 6 months ago

I didn't change the functionality for the detection.

Yep, understood. The only concern is because the detection for these browser variants hasn't been used until now, so it hasn't been thoroughly tested, it's not because it's changed at all.

pimterry commented 5 months ago

Now merged! :+1: Awesome work, thanks for contributing this. I've tested in Linux already and it's working well. It'll have to wait until I'm back next week to test and confirm on Mac, but I expect that'll be fine, and then this is good to go.

I'm not sure if you're aware, but HTTP Toolkit Pro is free for contributors - just let me know your email and I'll set you up with an account.

xKiian commented 5 months ago

Thanks, but i dont feel comfortable sharing my e-mail here. Can i send you an email?

pimterry commented 5 months ago

Sure, I'm tim @ httptoolkit.com

xKiian commented 5 months ago

Thanks!