search

httptoolkit / httptoolkit-server

The backend of HTTP Toolkit
https://httptoolkit.com
GNU Affero General Public License v3.0
433 stars 96 forks source link

fixed injecting script for devices with APEX #95

Closed mixalbl4-127 closed 9 months ago

mixalbl4-127 commented 9 months ago

for Z_PID in "$ZYGOTE_PID $ZYGOTE64_PID"; do

makes 1 string like "829 745" instead of array of 2 string "829" "745"

as a result we got correct 2 commands: nsenter --mount=/proc/829/ns/mnt -- nsenter --mount=/proc/845/ns/mnt -- instead of nsenter --mount=/proc/829 745/ns/mnt -- with nsenter: setns: Invalid argument result

CLAassistant commented 9 months ago

CLA assistant check
All committers have signed the CLA.

pimterry commented 9 months ago

Duh, yes, good catch! I'm sure that worked previously when I was testing it, I must have messed that up between the prototyping and the final version.

When you have a sec, can you confirm the CLA above? It's very short - it basically just confirms that you own the copyright for this change (it's not owned by your employer or similar) and that you're happy to give it to the project.

Code all looks good to me, and I can confirm this still works correctly on my main Android 14 test device (which has only Zygote64).

Just so I understand what's happening, for the device you're testing with:

Is that right? It's definitely an unusual setup I think (no idea what that apex is doing in this case) but if this works for you then I'm very happy to merge it.

Also, you mentioned Pro in the other issue - very happy to give you Pro for this! I've just added a year linked to your commit email. Reports & fixes like this are much appreciated, thank you :smile:. Just click 'Get Pro' in the app, then 'Log into existing account' and enter your email to get started.

mixalbl4-127 commented 9 months ago

It's definitely an unusual setup I think (no idea what that apex is doing in this case) but if this works for you then I'm very happy to merge it.

It was stock OnePlus 9 Pro. I unlocked bootloader, flashed Magisk 23, declined all formware updates. Thats all ) Google updates my services without asking me, but this is stock Android 11 :)

I've completed CLA )

pimterry commented 9 months ago

Merged - thanks again! :tada: