search

httptoolkit / httptoolkit-ui

The UI of HTTP Toolkit
https://httptoolkit.com
GNU Affero General Public License v3.0
282 stars 106 forks source link

New Theme #115

Closed xKiian closed 1 month ago

xKiian commented 3 months ago

I added a new theme named Dark Blue. Sadly, I couldn't figure out how to change the Monaco theme to a more blue one, but other than that, it's a great alternative to the normal dark mode.

Also, it would be cool to have a better theme switcher/manager. (I just had no idea how to implement it in a way where it doesn't look ugly.)

I also fixed a small bug in the 'send' tab where it showed the wrong color.

CLAassistant commented 3 months ago

CLA assistant check
All committers have signed the CLA.

xKiian commented 3 months ago

here are some screenshots of the theme:

grafik grafik grafik

pimterry commented 3 months ago

Nice work @xKiian! This looks great.

That said, this has come at a slightly unlucky time - if you look at the rebrand branch, there's a general UI styling update that's being worked on (with slightly different colours, a proper logo, a few small layout tweaks) and that includes various changes to the existing themes and their properties, that will have a few conflicts with this, and there's more changes coming there in future too.

You might find it interesting though as I did eventually work out how to modify the Monaco background colour :smile:

I'm also a bit cautious about adding more and more themes built into the tool... I think it would probably be better to make it easy for people to write & share themes themselves, and provide a UI button to easily load them into the app.

In that approach, you could publish this theme as a JSON file, and others could easily use it and share their own themes and modifications too. I'd be happy to add a page to the official docs explaining this and providing a link to any custom themes that people publish. What do you think?

xKiian commented 3 months ago

Yeah, that's a good idea.