Closed roschaefer closed 2 years ago
Sad that I cannot trigger the test pipeline with this PR.
Thanks @roschaefer, this looks great! Not sure what's going on with the local testing for you there, for whatever reason Karma can't seem to start Chrome on your machine. Not a big deal though, everything passes in CI and I'm happy to merge this as-is.
Sad that I cannot trigger the test pipeline with this PR.
Sorry, this is just standard GitHub open-source configuration - nowadays CI jobs never run automatically for PRs from new contributors.
I don't even know if it may happen in the normal use-case scenario that
exchanges
are empty. In this case,sourceStartTime
will be empty anddateFns.format
will complain.I would love to write a unit-test for this, but running
npm run test
gives the following output:For context: This is the only tiny fix from my attempt to use
mockttp
as a forward proxy to intercept network traffic. I used the code in this file to export a.har
file.