search

httptoolkit / httptoolkit-ui

The UI of HTTP Toolkit
https://httptoolkit.com
GNU Affero General Public License v3.0
292 stars 108 forks source link

colored http requests #72

Closed lavie707 closed 1 year ago

lavie707 commented 1 year ago

colored bad http requests in red, but not finsihed yet. Also remove redundant code from httptoolkit project

CLAassistant commented 1 year ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

pimterry commented 1 year ago

Hi @lavie707, can you explain what you're trying to do with this and #71? I'm definitely open to row highlighting improvements like this, but it'd be good to have a conversation about it first if you're planning functional changes. For example I'm not sure how you'd classify 'malicious' requests specifically - that's very ambiguous! Happy to discuss if you can open an issue and explain what you're trying to do.

It also looks like there's other changes here too unrelated to that - we can discuss those too, but it would be better to do that in a separate issue & pull request, instead of mixing things together if possible.