search

httptoolkit / httptoolkit-ui

The UI of HTTP Toolkit
https://httptoolkit.com
GNU Affero General Public License v3.0
282 stars 106 forks source link

fix: Add ENV option to allow legacy ssl for newer node versions and our older webpack #84

Closed mitchcapper closed 1 year ago

mitchcapper commented 1 year ago

Closes #76

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

pimterry commented 1 year ago

Hi @mitchcapper. This fixes it for Node 18+, but breaks things for Node 16, which is currently the officially supported version used. That's why the build is failing here.

Node 16 is still supported by the Node.js team for now, the only issue is that it's not the recommended version for new installs on the website at the moment. I definitely intend to upgrade, but there are issues (https://github.com/nodejs/node/issues/48519) that currently make that impossible in other components, so we're sticking with it for now.

Given all that, I think this probably is the right fix, but unless there's some way to make it work for both, it needs to stay unmerged here and wait until we do successfully move to Node 18+ everywhere. That's likely a couple of months from now.

In the meantime, if this is a growing issue, maybe it's worth adding a note to the README to point people in the right direction?

mitchcapper commented 1 year ago

MB I assumed the command line arg would just be ignored by older versions. Switched to using a javascript to generate the ENV file (native support w/ env-cmd) now use the flag conditionally.

pimterry commented 1 year ago

Neat! I didn't know env-cmd could do that, that works very nicely, merged :+1:

pimterry commented 1 year ago

Oh btw in case you're not aware, HTTP Toolkit Pro is free for contributors. I've just set up an account for the base gmail address from your GH profile (m.c@gmail.com). If that'd be useful to you, just click 'Get Pro', then 'Log into existing account' to log in. Thanks for contributing!