search

httptoolkit / mockttp

Powerful friendly HTTP mock server & proxy library
https://httptoolkit.com
Apache License 2.0
775 stars 88 forks source link

Fix pac proxy agent support #181

Closed smckee-r7 closed 6 days ago

smckee-r7 commented 1 week ago

Currently proxyUrl is broken when trying to use an external PAC file (#179). This small PR fixes this to allow proxyUrl to reference an external PAC file and have it be handled correctly.

CLAassistant commented 1 week ago

CLA assistant check
All committers have signed the CLA.

pimterry commented 6 days ago

Had to do a little update to TypeScript to handle some recent changes elsewhere, but that's all now sorted! Thanks for the contribution @smckee-r7 :smile:. In case you're not aware, HTTP Toolkit Pro is actually free for all contributors to repos in this org - I've just set that up now, linked to the email from your Git commits. If that's useful to you, just download HTTP Toolkit, click 'Get Pro' then 'Log into existing account' and enter your email.

Thanks again! I'll release this as Mockttp v3.15.3 shortly.

smckee-r7 commented 6 days ago

Thanks @pimterry, great stuff! Also really cool, I'll check it out when I get the chance!