httpwg / http-extensions

HTTP Extensions in progress
https://httpwg.org/http-extensions/
444 stars 146 forks source link

AD review for bcp56bis #1568

Closed fpalombini closed 3 years ago

fpalombini commented 3 years ago

As noted by the shepherd, the document should point to 3205 in the abstract and in the introduction to mention it obsoletes it. From https://www.ietf.org/standards/ids/checklist/: "If your document obsoletes or updates a previous RFC, then:

FP: Not completely clear what "update or modify" means. What is the difference between updating and modifying an IANA registry? And I assume in this case updating or modifying only aims to indicate changes to the registry as a whole (for example, adding a new column, changing all values etc), and registering a new value is not considering modifying a registry, is this assumption correct? In any case, it would be good to clarify.

FP: I understand the motivation for it, but I don't think this last part of the sentence helps the reader, because of its vagueness.

FP: "different set of methods" than those it should according to ... (Might use some clarification)

FP: the benefits mentioned here are not specified above, is it those mentioned in section 3.3?

FP: Since this affect interoperability, why is the "should not" not BCP 14 "SHOULD NOT"?

FP: I am not sure about what "its" refers to.

FP: nit - s/using/use

FP: nit - replace the first "the" with "then"

FP: s/7049/8949 (and update reference)

FP. nit - s/need/needs

FP: Section 4.4.2 does not require, but RECOMMENDS the use of https.

mnot commented 3 years ago

I've mentioned 3205 in the abstract, although I'll once again register my scepticism about the utility of doing so, considering that the same information is a few lines above in the document header.

mnot commented 3 years ago

FP: Since this affect interoperability, why is the "should not" not BCP 14 "SHOULD NOT"?

This document shies away from most requirements, since it's giving advice to protocol designers, rather than actually specifying a protocol. This was discussed at some length in community feedback to work on the IAB 'for the users' draft.

mnot commented 3 years ago

@fpalombini thanks so much - very helpful feedback. I think these are all addressed.

fpalombini commented 3 years ago

Thank you @mnot for addressing everything :) I assume you will close this when submitting the update?

mnot commented 3 years ago

Should I publish an update now, or wait until LC is done (tomorrow, I think)?

fpalombini commented 3 years ago

Might be worth waiting for the Genart and Secdir reviews, which are due tomorrow... but either way, whatever you prefer.