search

hturner / PlackettLuce

PlackettLuce package for Plackett-Luce models in R
https://hturner.github.io/PlackettLuce/
18 stars 5 forks source link

Make tree models either fully optional or fully part of package #27

Closed hturner closed 6 years ago

hturner commented 6 years ago

Currently psychotree is in Suggests while partykit and sandwich are in Imports. I think all 3 only needed for trees.

hturner commented 6 years ago

Three options:

  1. Move partykit and sandwich to suggests. This gets messy to require relevant packages as necessary, e.g. when plotting or getting fitted values for a "pltree" object (potentially not created in same session).
  2. Move psychotree to imports. Currently required by itempar and plot.pltree, so can fit tree without psychotree, but these methods fail/don't work fully at the moment.
  3. Move plfit to psychotools; move pltree to psychotree. psychotree depends on psychotools and partykit so (if also psychotools rexported estfun from sandwich ) would only need to load psychotree to use trees).

Do 2. as simplest solution for now; consider 3. for later.