Closed lauralgh closed 2 months ago
@bkleinen should we change the image file names here or should we push our changes to the other pull request?
enthält dateinamen mit spaces. Bitte updaten dann findet mein script die auch :)
There is no option to request a review in the upper right. How do we fix this?
verstehe. Hab's geändert: https://github.com/htw-imi-showtime/showtime-website/commit/34b196fc28442dba5ba0225635892217405530fa
There is no option to request a review in the upper right. How do we fix this?
Opening a Pull Request to Update your Project
Please follow these Steps & Guidelines for your Pull Request:
Before you Request a Review Check and Tick these Boxes:
[x] make sure that the hugo site build works and check the result visually. [x] merge your local branch with upstream/main (see update doc) [x] Deploy the Site on your github pages by activating the "Deploy Page using GH-Actions" Workflow in "gh-pages-action.yml" [x] make sure that your PR contains only files / file changes within your project subdirectory. [x] make sure that all your file names consist only of lower case letters, numbers, or [-_.] - with only one . for the file extension [x] delete all unnecessary files from your PR (including cat.jpg and kitty.jpg) [x] check the image file sizes. All Images have to be as small as possible. See ./doc/disk_usage.md about this issues, there's a script: ./bin/images-smaller.sh
Note that if you fail to do so, I may simply reduce the file sizes brute force using the script above - WITHOUT CHECKING THE QUALITY
[] if everythings seems fine, request a review by bkleinen on github. (on the upper right)
Fill out this Information:
Added content to process and added pictures of team members.
URL of your Preview Site Containing the Changes: https://lauralgh.github.io/showtime-website/
When did your Project Supervisor review your changes? (Date/Note or require review for PR):
If your disk usage exceeds 500K, provide a reason while you want to include so many images or why certain images need to be that big:
If the checks fail...
if you cannot figure out why a check fails or you think that it may be wrong, don't hesitate to contact me! (e.g. by requesting a review and commenting in the pr)
run the checks locally with:
./bin/check-project-update-pr/run-all.sh
All good? Request a Review!
[] if everything seems fine, request a review by bkleinen on github. (on the upper right)
More Information
We are using the Forking Workflow.