gerritbehrens
commented
3 months ago Hallo,
ich sehe gerade, dass der Titel des PR angeblich falsch sein soll. Das verstehe ich nicht. Ich könnte mir vorstellen, dass das Problem an den Anführungszeichen im Titel lag. Die habe ich jetzt entfernt, kann aber leider keine weitern Actions anstoßen.
Auch kann ich kein Review bei Carsten Busch anfordern. Ich werde ihm wieder ein Email schreiben, aber ich bitte Sie ihm ebenfalls bescheid zu geben. Vielleicht können Sie ihn auch als Reviewer hinzufügen.
Vielen Dank und viele Grüße
bkleinen
Opening a Pull Request to Update your Project
I've started a documentation on how we should use the forking workflow here:
https://github.com/htw-imi-showtime/showtime-website/blob/documentation/doc/forking-workflow/index.md (will not be merged to main due to file sizes)
Please follow these Steps & Guidelines for your Pull Request:
Before you Request a Review Check and Tick these Boxes:
[X] make sure that the hugo site build works and check the result visually. [X] merge your local branch with upstream/main (see update doc) [X] Deploy the Site on your github pages by activating the "Deploy Page using GH-Actions" Workflow in "gh-pages-action.yml" [X] make sure that your PR contains only files / file changes within your project subdirectory. [X] make sure that all your file names consist only of lower case letters, numbers, or [-_.] - with only one . for the file extension [X] delete all unnecessary files from your PR (including cat.jpg and kitty.jpg) [X] check the image file sizes. All Images have to be as small as possible. See ./doc/disk_usage.md about this issues, there's a script: ./bin/images-smaller.sh
Note that if you fail to do so, I may simply reduce the file sizes brute force using the script above - WITHOUT CHECKING THE QUALITY
[] if everythings seems fine, request a review by bkleinen on github. (on the upper right)
Fill out this Information:
Change the PR Title to: (e.g. B0 - update techstack.md) and describe your changes:
URL of your Preview Site Containing the Changes: https://gerritbehrens.github.io/showtime-website/
When did your Project Supervisor review your changes? (Date/Note or require review for PR):
If your disk usage exceeds 500K, provide a reason while you want to include so many images or why certain images need to be that big:
IMPORTANT: if you run into trouble / If the checks fail...
if you cannot figure out why a check fails or you think that it may be wrong, don't hesitate to contact me! (e.g. by requesting a review and commenting in the pr)
run the checks locally with:
./bin/check-project-update-pr/run-all.sh
All good?
If all checks run successfully the PR will be reviewed and, if no further changes are requested, merged and closed. (this is the time to update and start a new branch!)
More Information
We are using the Forking Workflow.