search

htwaijry / npy4th

Numpy format for Torch
Other
68 stars 8 forks source link

''luarocks make'' gives "void value not ignored as it ought to be" error, and a possible fix #8

Closed jiajunwu closed 7 years ago

jiajunwu commented 8 years ago

Running ''luarocks make" gave me the error: "void value not ignored as it ought to be" on all _cnpy::npysave function calls (npy4th.cpp line 151, 157, ...), though I noticed cnpy/cnpy.h is already returning bool.

This could be due to I installed npy4th v1.2 earlier, and there was a cnpy.h somewhere else in the system as the earlier version might return void.

An easy fix is to hard code the path include "cnpy/cnpy.h" instead of include at line 8 of npy4th.cpp . It'd be great to fix this in the repo as it may benefit other people with a similar issue.

htwaijry commented 8 years ago

Thanks for finding this out! It does seem to be an issue with updating from 1.2. I'm not sure why cnpy.h installation is not being updated though.

I think I should figure out how to bundle cnpy in a better way. I'll get a fix in there.

Thanks again!

jiajunwu commented 8 years ago

That sounds great. Thanks!